Skip to content

Single step importer API does not work as specified #3344

@siepkes

Description

@siepkes

The single step importer API as described here does not work as specified.

For example the convertPlaceholdersToIcu field is listed as "required" but Tolgee will happily accept input without it. As a matter of fact, it will just ignore the field at all. Setting it to true does nothing and Tolgee will process the input as if it was set to false.

This seems to be caused by this code which overrides various settings and assumes the can't be configured:

// these options are not user accessible,
// because it might act weird when just importing screenshots without any actual translations
// leaving this for an actual usecase as it's now not clear how it should behave
request.convertPlaceholdersToIcu = false
request.tagNewKeys = emptyList()
request.fileMappings = keysToFilesManager.getFileMappings()
request.removeOtherKeys = false
request.createNewKeys = true

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions