-
-
Notifications
You must be signed in to change notification settings - Fork 319
Open
Description
The single step importer API as described here does not work as specified.
For example the convertPlaceholdersToIcu field is listed as "required" but Tolgee will happily accept input without it. As a matter of fact, it will just ignore the field at all. Setting it to true does nothing and Tolgee will process the input as if it was set to false.
This seems to be caused by this code which overrides various settings and assumes the can't be configured:
tolgee-platform/backend/data/src/main/kotlin/io/tolgee/service/dataImport/SingleStepImportService.kt
Lines 112 to 119 in df527ba
| // these options are not user accessible, | |
| // because it might act weird when just importing screenshots without any actual translations | |
| // leaving this for an actual usecase as it's now not clear how it should behave | |
| request.convertPlaceholdersToIcu = false | |
| request.tagNewKeys = emptyList() | |
| request.fileMappings = keysToFilesManager.getFileMappings() | |
| request.removeOtherKeys = false | |
| request.createNewKeys = true |
Metadata
Metadata
Assignees
Labels
No labels