[Do Not Merge] Test Storage swagger generated by TSP #28984
Conversation
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull request overview
This pull request integrates a TypeSpec-generated (TSP) Storage service SDK into the Azure PowerShell repository. The changes reflect a shift from manually crafted Swagger definitions to a TypeSpec-based code generation approach, resulting in updates to auto-generated SDK code, updated documentation, and various code changes to accommodate the new generated types and interfaces.
Key Changes
- Updated the Storage.Management.Sdk to use TypeSpec-generated code from a consolidated OpenAPI specification file
- Introduced new operation groups for Tables and Storage Task Assignments
- Modified existing model types to use more specific enum types instead of generic ones
- Updated help documentation with additional parameter descriptions
Reviewed changes
Copilot reviewed 22 out of 224 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Storage.sln | Updated project GUID for Az.Storage reference |
| README.md | Changed to use consolidated OpenAPI spec from TypeSpec generation |
| StorageManagementClient.cs | Added new operation groups and changed SubscriptionId type from string to Guid |
| PSShare.cs | Added ParseDateTimeString method to handle date string parsing |
| PSNetworkRule.cs | Refactored to use specific enum types for different rule actions |
| InvokeAzureStorageAccountFailover.cs | Updated to use Enum56 instead of FailoverType |
| GetAzureStorageAccountKey.cs | Updated to use Enum70 instead of ListKeyExpand |
| Multiple help files | Added UUID requirement description for SubscriptionId parameters |
| TableOperations.cs, TableServicesOperations.cs, StorageTaskAssignmentsOperations.cs | New auto-generated operation classes |
| commit: ec3df311a63c6e653824b4018bb1a39d483bf9fc | ||
| input-file: | ||
| - https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/storage.json | ||
| - https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/blob.json | ||
| - https://github.com/Azure/azure-rest-api-specs/blob/$(commit)/specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/file.json | ||
| - https://github.com/Azure/azure-rest-api-specs/blob/main/specification/storage/resource-manager/Microsoft.Storage/stable/2025-06-01/openapi.json |
There was a problem hiding this comment.
This README references the API specification using a branch name ("main") instead of a commit hash. According to Azure PowerShell conventions for AutoRest projects, API specifications should always be referenced using specific commit hashes to ensure reproducible builds and prevent breaking changes when the specification repository evolves. The previous configuration correctly used a commit hash.
1 participant
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.