feat: Add EnvoyProxyTemplate for global Envoy Proxy defaults #7698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgs255
force-pushed
the
allow-provide-default-proxy-image
branch
2 times, most recently
from
7da24bf to
02beef5
Compare
zirain
reviewed
Dec 8, 2025
mgs255
force-pushed
the
allow-provide-default-proxy-image
branch
3 times, most recently
from
fd2a520 to
0ae8e1d
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7698 +/- ##
==========================================
- Coverage 72.40% 72.35% -0.06%
==========================================
Files 234 235 +1
Lines 34562 34609 +47
==========================================
+ Hits 25026 25041 +15
- Misses 7748 7772 +24
- Partials 1788 1796 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zirain
reviewed
Dec 11, 2025
arkodg
reviewed
Dec 11, 2025
arkodg
reviewed
Dec 11, 2025
mgs255
force-pushed
the
allow-provide-default-proxy-image
branch
from
0ae8e1d to
804ff4b
Compare
mgs255
force-pushed
the
allow-provide-default-proxy-image
branch
4 times, most recently
from
23b261c to
ff220ab
Compare
mgs255
force-pushed
the
allow-provide-default-proxy-image
branch
2 times, most recently
from
4b9211d to
e5283b6
Compare
Introduce EnvoyProxyTemplate in EnvoyGateway provider configuration to define default settings for all Envoy Proxy deployments. This establishes a 3-level hierarchy: Template → GatewayClass → Gateway, where settings at each level override those from lower levels, with Gateway settings having the highest precedence. All non scalar fields (env vars, volumes, volumeMounts, annotations etc) are now merged rather than replaced, allowing settings to be combined across all three levels. - Add EnvoyProxyTemplate field to EnvoyGatewayKubernetesProvider API - Add EnvoyProxyTemplate field to Translator for template access - Create MergeEnvoyProxyConfigs to support 3-level merge hierarchy - Update IsMergeGatewaysEnabled to be aware of the template. - Add strategic merge patch directives to enable array field merging - Add table-driven tests in testdata/envoyproxy-merge/ Fixes: envoyproxy#4764 Signed-off-by: Michael Sommerville <msommerville@gmail.com>
mgs255
force-pushed
the
allow-provide-default-proxy-image
branch
from
e5283b6 to
c198efe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce EnvoyProxyTemplate in EnvoyGateway provider configuration to define default settings for all Envoy Proxy deployments. This establishes a 3-level hierarchy: Template → GatewayClass → Gateway, where settings at each level override those from lower levels, with Gateway settings having the highest precedence.
All non scalar fields (env vars, volumes, volumeMounts, annotations etc) are now merged rather than replaced, allowing settings to be combined across all three levels.
Fixes: #4764