fix(core): Set op on ended Vercel AI spans #18553
Open
+29
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chargome
requested changes
Dec 18, 2025
Comment on lines
+121
to
+144
| if (name && (span.op === 'default' || !span.op)) { | ||
| if ( | ||
| name === 'ai.generateText' || | ||
| name === 'ai.streamText' || | ||
| name === 'ai.generateObject' || | ||
| name === 'ai.streamObject' || | ||
| name === 'ai.embed' || | ||
| name === 'ai.embedMany' | ||
| ) { | ||
| span.op = 'gen_ai.invoke_agent'; | ||
| } else if (name === 'ai.generateText.doGenerate') { | ||
| span.op = 'gen_ai.generate_text'; | ||
| } else if (name === 'ai.streamText.doStream') { | ||
| span.op = 'gen_ai.stream_text'; | ||
| } else if (name === 'ai.generateObject.doGenerate') { | ||
| span.op = 'gen_ai.generate_object'; | ||
| } else if (name === 'ai.streamObject.doStream') { | ||
| span.op = 'gen_ai.stream_object'; | ||
| } else if (name === 'ai.embed.doEmbed') { | ||
| span.op = 'gen_ai.embed'; | ||
| } else if (name === 'ai.embedMany.doEmbed') { | ||
| span.op = 'gen_ai.embed_many'; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think a cleaner approach would be to determine the name with a map here.
| name === 'ai.embed' || | ||
| name === 'ai.embedMany' | ||
| ) { | ||
| span.op = 'gen_ai.invoke_agent'; |
Member
There was a problem hiding this comment.
We're generally using constants for these attributes, you'll find other occurrences in this file.
| ) { | ||
| span.op = 'gen_ai.invoke_agent'; | ||
| } else if (name === 'ai.generateText.doGenerate') { | ||
| span.op = 'gen_ai.generate_text'; |
Member
There was a problem hiding this comment.
op should be updated like this:
span.setAttribute(SEMANTIC_ATTRIBUTE_SENTRY_OP, YOUR_AI_ATTRIBUTE);
chargome
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
span.opfor Vercel AI spans during ended-span processing when it is missing or stilldefault.onVercelAiSpanStartreturns early (for example, AI SDK attributes required for op mapping are not present at span start).Context
Fixes #18448.
PR #18471 relaxed the spanStart guard to require only
ai.model.id, but this can still be insufficient if the attributes needed for op mapping aren't reliably present at span start. SinceprocessEndedVercelAiSpanalready normalizes AI attributes on ended spans, it's a good place to also ensurespan.opis set.FAQ
Q: Why aren't these spans getting a
gen_ai.*op at span start? Is the user setup wrong?A: Usually nothing is wrong with the user setup. The integration sets
span.opin thespanStarthook, but it gates that work on AI SDK attributes being present at span start (for exampleai.model.id). In practice, the AI SDK / OpenTelemetry instrumentation may attach some of those attributes after the span has started (for example once the provider response/usage is known). In that caseonVercelAiSpanStartcan return early and the span remainsop=default. The ended-span event processor already runs after those attributes exist (it renames them togen_ai.*), so setting the op there provides the needed fallback for the AI Agents UI.Test plan
ai.*spans no longer haveop=defaultand are classified asgen_ai.*(and appear in AI Agents).