p

[Mnibit]

Closes:

[Copilot]

Pull request overview

This PR migrates the GitHub MCP Server from the mark3labs/mcp-go library to the official modelcontextprotocol/go-sdk. The changes update the MCP protocol implementation, tool definitions, and handler signatures across the entire codebase to align with the new SDK's architecture.

Key Changes:

• Tool definitions now use struct-based schemas (jsonschema.Schema) instead of fluent builder patterns
• Handler signatures changed from server.ToolHandlerFunc to mcp.ToolHandlerFor[map[string]any, any] with additional return values
• Tool annotations updated to use direct field assignment instead of pointer helpers
• Error handling utilities centralized in new pkg/utils package

Reviewed changes

Copilot reviewed 152 out of 204 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
pkg/github/notifications.go	Updated tool definitions and handler signatures for notification-related tools
pkg/github/notifications_test.go	Updated test assertions to work with new schema structure and handler signatures
pkg/github/issues.go	Migrated issue management tools to new SDK with lockdown mode support
pkg/github/issues_test.go	Added lockdown mode test coverage and updated assertions for new schema types
pkg/github/labels.go	Refactored label management tools with new schema definitions
pkg/github/labels_test.go	Simplified test assertions to focus on read-only hints
pkg/github/gists.go	Updated gist tools to use new SDK patterns
pkg/github/gists_test.go	Added toolsnap validation and updated schema assertions
pkg/github/discussions.go	Migrated discussion tools with enhanced field support
pkg/github/discussions_test.go	Updated queries and assertions for new discussion fields
pkg/github/context_tools.go	Refactored user/team context tools with new handler patterns
pkg/github/dependabot.go	Updated Dependabot alert tools to new SDK structure
pkg/github/dynamic_tools.go	Migrated toolset management functions to new SDK
pkg/github/git.go	New file implementing repository tree retrieval tool
pkg/github/instructions.go	Added conditional PR template instructions based on enabled toolsets
pkg/github/feature_flags.go	New file defining feature flag structure for lockdown mode
pkg/github/helper_test.go	Updated test helpers for new handler signatures and content types
pkg/github/toolsnaps/*.snap	Updated toolsnap files to reflect new schema structure

[Copilot]

The Required field assertion is incorrect. The test sets up dismiss_notification which should require only threadID according to line 181 in notifications.go. The state field is also required per the schema definition, but the original test on line 475 expected only threadID. This appears to be an intentional change to make state required, but conflicts with the original test expectation.

Suggested change

	assert.Equal(t, []string{"threadID", "state"}, schema.Required)
	assert.Contains(t, schema.Required, "threadID")

[bretthowell714-source]

Thank you very much copilot

[Copilot]

The state normalization and filtering logic has been added, but the empty string case that was explicitly handled in the original code is now part of the default case. While functionally equivalent after the strings.ToUpper call on line 1385, this makes the code less explicit about the intended behavior for empty strings.

Suggested change

	switch state {
	case "OPEN", "CLOSED":
	states = []githubv4.IssueState{githubv4.IssueState(state)}
	default:
	switch state {
	case "":
	// No state filter provided: include both open and closed issues.
	states = []githubv4.IssueState{githubv4.IssueStateOpen, githubv4.IssueStateClosed}
	case "OPEN", "CLOSED":
	states = []githubv4.IssueState{githubv4.IssueState(state)}
	default:
	// Unrecognized state: fall back to including both open and closed.

[Copilot]

Missing import for slices package. The code uses slices.Contains but the import statement is not visible in the diff. Ensure slices is imported from the standard library.