Skip to content

Conversation

@KSNauman
Copy link
Contributor

@KSNauman KSNauman commented Dec 12, 2025

Notes for Reviewers
this was the only best way i found out by changing the DEFAULT_FILL_NONE = "none" to DEFAULT_FILL_NONE="currentcolor"
This PR fixes #663

Signed commits

  • Yes, I signed my commits.

@Rajesh-Nagarajan-11
Copy link
Member

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~1 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin defaultIcon/nauman/663

Signed-off-by: KSNauman <ksnauman639@gmail.com>
@KSNauman KSNauman force-pushed the defaultIcon/nauman/663 branch from 37f2859 to 1be222c Compare December 12, 2025 13:20
@saurabhraghuvanshii
Copy link
Contributor

Can you attach screenshot of changes

@KSNauman
Copy link
Contributor Author

yeah sure
Screenshot (626)

@saurabhraghuvanshii
Copy link
Contributor

@KSNauman also attach before changes Screenshot

@KSNauman
Copy link
Contributor Author

Before :
When icons were used with the default fill="none", they were rendered but not visible .

Screenshot (625) After : After updating the default fill to currentColor, the same icons render correctly Screenshot (626)

@kishore08-07
Copy link

@KSNauman
Thank you for your contribution!
Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT
Add it as an agenda item to the meeting minutes, if you would :)

@Rajesh-Nagarajan-11 Rajesh-Nagarajan-11 merged commit 16d0807 into layer5io:master Dec 16, 2025
2 of 4 checks passed
@Rajesh-Nagarajan-11
Copy link
Member

@KSNauman Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Icons set to filled by default

4 participants