Fix: Update bufferSubData parameters to match WebGL 1 spec #42315 #42411
+1
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed WebGL 2 constants from target. Removed srcOffset and length parameters which are not supported in WebGL 1. Renamed dstByteOffset to offset.
Harish3005-cloud
requested review from
hamishwillee
and removed request for
a team
github-actions
bot
added
Content:WebAPI
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
files/en-us/web/api/webglrenderingcontext/buffersubdata/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed WebGL 2 constants from target. Removed srcOffset and length parameters which are not supported in WebGL 1. Renamed dstByteOffset to offset.
Description
Updated the
bufferSubDatadocumentation forWebGLRenderingContextto accurately reflect the WebGL 1 specification. I removed parameters and constants that are only available in WebGL 2 and corrected a parameter name to match the method signature.Motivation
The current documentation incorrectly lists
srcOffsetandlengthas parameters, but these are only supported inWebGL2RenderingContext. Additionally, thetargetparameter listed constants (likeCOPY_READ_BUFFER) that are not valid in a WebGL 1 context. This created confusion for developers using the WebGL 1 API.Additional details
These changes align the documentation with the WebGL 1.0 Specification.
Related issues and pull requests
Fixes #42315
Related issues and pull requests