HELP-85556 - fix PVC scaling ignoring namespaces #651
+86
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCK 1.6.2 Release NotesBug Fixes
|
lucian-tosa
approved these changes
Dec 17, 2025
| } | ||
| } | ||
|
|
||
| err = resizePVCsStorage(fakeClient, createStatefulSet("test", "mongodb-test", "30Gi", "30Gi", "20Gi"), zap.S()) |
Contributor
There was a problem hiding this comment.
nit: could you add a comment above this line to explain that we are resizing initialSts?
MaciejKaras
commented
Dec 18, 2025
|
|
||
| log.Infof("Detected PVC size expansion; patching all pvcs and increasing the size for sts: %s", desiredSts.Name) | ||
| if err := resizePVCsStorage(memberClient, desiredSts); err != nil { | ||
| if err := resizePVCsStorage(ctx, memberClient, desiredSts, log); err != nil { |
Collaborator
Author
There was a problem hiding this comment.
resizePVCsStorage() function did not receive parent context, this is fixed now
MaciejKaras
commented
Dec 18, 2025
| // Cascade delete the StatefulSet | ||
| deletePolicy := metav1.DeletePropagationOrphan | ||
| if err := memberClient.Delete(context.TODO(), desiredSts, client.PropagationPolicy(deletePolicy)); err != nil && !apiErrors.IsNotFound(err) { | ||
| if err := memberClient.Delete(ctx, desiredSts, client.PropagationPolicy(deletePolicy)); err != nil && !apiErrors.IsNotFound(err) { |
Collaborator
Author
There was a problem hiding this comment.
memberClient.Delete used background context and not parent context
MaciejKaras
commented
Dec 18, 2025
| func resizePVCsStorage(ctx context.Context, kubeClient kubernetesClient.Client, statefulSetToCreate *appsv1.StatefulSet, log *zap.SugaredLogger) error { | ||
| // this is to ensure that requests to a potentially not allowed resource is not blocking the operator until the end | ||
| ctx, cancel := context.WithTimeout(context.Background(), 2*time.Minute) | ||
| ctx, cancel := context.WithTimeout(ctx, 2*time.Minute) |
Collaborator
Author
There was a problem hiding this comment.
now properly creating a context with timeout from parent context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We are ignoring namespaces when listing PVCs to resize and if customer has multiple resources named exactly the same, but in different namespaces, we will try to resize them all. This fix adds namespace filtering in
resizePVCsStorage+ more accurate logging when actual resize is requested.Additionally fixed issues with missing context propagation. These fixes are commented in the PR.
Proof of Work
Updated unit tests that verify
resizePVCsStoragelogic.Checklist
skip-changeloglabel if not needed