19.0 Estate tutorial (VIKRI) #1078

vikri-odoo · 2025-12-16T12:42:40Z

Here I have created new add-on for on-boarding tutorial project

robodoo · 2025-12-16T12:42:43Z

barracudapps

Some comments here and there. Can you also please review your PR title and description following our guidelines (https://www.odoo.com/documentation/19.0/contributing/development/git_guidelines.html)?
A clear commit message is really important to describe what you did and why you did it.

barracudapps · 2025-12-16T14:40:00Z

real_estate/__init__.py

@@ -0,0 +1 @@
+from . import models


Don't forget Unix conventions on text files' structure based on a line definition (cf. https://peps.python.org/pep-0008/ and https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206)

Suggested change

from . import models

from . import models

Please review all your files

thanks for the documentation clear. I have added ruff now so it'll do the formatting from now on.

barracudapps · 2025-12-16T14:42:13Z

real_estate/__manifest__.py

+    'version': '0.1',
+
+    'application': True,
+    'installable': True,


installable is true by default (at least with application) so not required

removed installable and used application only as suggested.

barracudapps · 2025-12-16T14:42:16Z

real_estate/__manifest__.py

+    # Categories can be used to filter modules in modules listing
+    # Check https://github.com/odoo/odoo/blob/15.0/odoo/addons/base/data/ir_module_category_data.xml
+    # for the full list


Not needed here as obvious, just remove these lines

removed the unused comment lines

barracudapps · 2025-12-16T14:43:23Z

real_estate/__manifest__.py

+    'summary': """
+        This is a custom real estate application for understanding Odoo
+    """,


Try to keep as much single-lines as possible. Same further.

As mentioned, since it's just one line made one liner string.

barracudapps · 2025-12-16T15:40:04Z

real_estate/models/estate.py

+
+class Estate(models.Model):
+    _name = 'estate'
+    _description = 'Real_Estate'


Use double quotes for non-technical strings

got it and made the non-technical strings in single quotes

barracudapps · 2025-12-16T15:43:44Z

real_estate/views/estate_menu.xml

+
+        <menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>
+


Suggested change

<menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>

<menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>

Avoid useless spaces. Here, the file is still readable without spaces

thanks will removed the spaces and extra lines.

barracudapps · 2025-12-16T15:45:00Z

website_airproof/data/presets.xml

        <field name="active" eval="False"/>
    </record>
-    <!-- Enable product categories in the left // View template in: odoo/addons/website_sale/views/templates.xml -->
+    <!-- Enable product categories in the left // View template in: odoo/addons/website_sale/views/estate_templates.xml -->


This can be moved to the commit message if you want to explicitly explain your choice

it was a mistake from my end and reverted the changes in this line

Completed till chapter 7 many to one

Added new tags model to understand many2many

barracudapps · 2025-12-18T08:08:50Z

real_estate/models/estate_property.py

    postcode = fields.Char(string="Postcode")
-    date_availability = fields.Datetime(string="Date Availability", default=_set_default_start_date(), copy=False)
+    date_availability = fields.Datetime(
+        string="Date Availability", default=_set_default_start_date(), copy=False


Add a trailing coma here so if someone has to add a new parameter on a new line, that person won't have to change your line (and change the git history)

barracudapps · 2025-12-18T08:09:33Z

real_estate/data/res_estate_data.xml

            <field name="description">Description 3</field>
            <field name="postcode">1040</field>
-            <field name="date_availability" eval="DateTime.now()" />
+            <field name="date_availability" eval="DateTime.now()"/>


date_availability is already pre-defined in your model with your default value

barracudapps · 2025-12-18T08:11:49Z

real_estate/models/estate_property.py

+    state = fields.Selection(
+        string="State",
+        selection=[
+            ("new", "New"),


Use double quotes (") only for non-technical strings.
Please check all your files

barracudapps · 2025-12-18T08:12:35Z

real_estate/security/ir.model.access.csv

 access_estate_property,access.estate.property,model_estate_property,base.group_user,1,1,1,1
-access_estate_property_type,access.estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_property_type,access.estate.property.type,model_estate_property_type,base.group_user,1,1,1,1
+access_estate_property_tags,access.estate.property.tags,model_estate_property_tags,base.group_user,1,1,1,1


Don't forget Unix conventions on text files' structure based on a line definition (cf. https://peps.python.org/pep-0008/ and https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206)

Check other files too

barracudapps · 2025-12-18T08:14:26Z

real_estate/views/estate_menu.xml

+    <menuitem
            id="estate_menu_action"
            action="test_model_action"
            parent="estate_menu_root"
            sequence="1"
-        />


You can keep this on a single line. It's not always easy to know when to write multiple lines but the basic rule is that you try to optimize readability AND number of lines

barracudapps · 2025-12-18T08:15:48Z

real_estate/views/estate_property_templates.xml

 <?xml version="1.0"?>
 <odoo>
-<!--    Root menuitem action which will help us to see the default action window-->
+    <!--    Root menuitem action which will help us to see the default action window-->


This comment is useless as the majority of the developers will easily know what your code is doing

Check the style guide and resolve the issues

[ADD] new addon for real estate onboarding project

36e0588

barracudapps requested changes Dec 16, 2025

View reviewed changes

[ADD] add the new model for property types

528b3cf

Completed till chapter 7 many to one

vikri-odoo changed the title ~~[ADD] new addon for real estate onboarding project~~ 19.0 Estate tutorial (VIKRI) Dec 17, 2025

[LINT] format the code using ruff

abc57b5

Added new tags model to understand many2many

barracudapps requested changes Dec 18, 2025

View reviewed changes

vikri-odoo added 2 commits December 18, 2025 10:00

[REF] address the PR comments and resole it

247d7ca

Check the style guide and resolve the issues

[REF] update the default availability method to lamda

66c0381


		<menuitem id="estate_first_level_menu" name="Advertisements" parent="estate_menu_root"/>

19.0 Estate tutorial (VIKRI) #1078

Are you sure you want to change the base?

19.0 Estate tutorial (VIKRI) #1078

Conversation

vikri-odoo commented Dec 16, 2025

Uh oh!

robodoo commented Dec 16, 2025

Uh oh!

barracudapps left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants