Fix -Wconf:src Windows path conversion #24772
Open
+59
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the -Wconf:src filter to avoid using
java.nio.file.Path.toURIin order to fix Windows source path conversions.Path.toURIprepends the current working directory to Windows-like paths unconditionally, and converts backslashes in such paths to%5Cescape sequences This can cause-Wconf:srcfilters that work on non-Windows platforms to fail on Windows.For example, before this change, the
Path.toURIconversion in theSourcePatterncase fromMessageFilter.matches()produced:After this change, it produces the following, which still prepends the current working directory, but properly converts path separators to
/:This change is based on scala/scala#11192, and also adapts some test cases from that pull request to validate symlink and normalized path handling. This change also extracts the
diagnosticWarninghelper method to reduce duplication between new and existing test cases.Fixes #24771. Review by @lrytz.