Throw SecurityError on non-trustworthy URLs in fetchLater
#1858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per https://github.com/web-platform-tests/wpt/blob/c009ca2fa7d311b1a257222aa0f9fd7706ffa4d6/fetch/fetch-later/basic.https.window.js#L54-L59 it should not throw a `TypeError`, but a `SecurityError` instead.
Member
|
cc @noamr |
Member
|
I wonder if the test is wrong here. I think we decided that we should align with |
Contributor
Yea that's what I recall as well. |
Contributor
Author
|
As part of the Servo PR I can update the test. Shall I? |
Member
|
Yeah please. After that this PR can be closed. Thank you! |
Contributor
Thanks for opening these issues as part of Servo, it helps makes the specs & general interop bettter! |
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Oct 1, 2025
Allows fetches to be deferred, only in a secure context. It does not yet implement quota computation, since we don't have a concept of document quota yet. Also update the `fetch/api/idlharness` test to run in a secure context, since this API is only available there. Positive Mozilla position: mozilla/standards-positions#703 Positive WebKit position: WebKit/standards-positions#85 Closes whatwg/fetch#1858 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Oct 2, 2025
Allows fetches to be deferred, only in a secure context. It does not yet implement quota computation, since we don't have a concept of document quota yet. Also update the `fetch/api/idlharness` test to run in a secure context, since this API is only available there. Positive Mozilla position: mozilla/standards-positions#703 Positive WebKit position: WebKit/standards-positions#85 Closes whatwg/fetch#1858 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/web-platform-tests/wpt/blob/c009ca2fa7d311b1a257222aa0f9fd7706ffa4d6/fetch/fetch-later/basic.https.window.js#L54-L59 it should not throw a
TypeError, but aSecurityErrorinstead.Preview | Diff